From: David L Stevens Date: Wed, 31 Mar 2010 18:20:31 +0000 (+0300) Subject: vhost: fix features ack X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dc14a397812b91dd0d48b03d1b8f66a251542369;p=qemu.git vhost: fix features ack vhost driver in qemu didn't ack features, and this happens to work because we don't really require any features. However, it's better not to rely on this. This patch passes features to vhost as guest acks them. Signed-off-by: David L Stevens Signed-off-by: Michael S. Tsirkin Signed-off-by: Aurelien Jarno --- diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 970ba06275..acb3cec7cb 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -219,6 +219,14 @@ static void virtio_net_set_features(VirtIODevice *vdev, uint32_t features) (features >> VIRTIO_NET_F_GUEST_ECN) & 1, (features >> VIRTIO_NET_F_GUEST_UFO) & 1); } + if (!n->nic->nc.peer || + n->nic->nc.peer->info->type != NET_CLIENT_TYPE_TAP) { + return; + } + if (!tap_get_vhost_net(n->nic->nc.peer)) { + return; + } + return vhost_net_ack_features(tap_get_vhost_net(n->nic->nc.peer), features); } static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd,