From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Mon, 24 Dec 2018 05:45:56 +0000 (-0800)
Subject: tipc: fix a double free in tipc_enable_bearer()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dc4501ff287547dea7ca10f1c580c741291a8760;p=linux.git

tipc: fix a double free in tipc_enable_bearer()

bearer_disable() already calls kfree_rcu() to free struct tipc_bearer,
we don't need to call kfree() again.

Fixes: cb30a63384bc ("tipc: refactor function tipc_enable_bearer()")
Reported-by: syzbot+b981acf1fb240c0c128b@syzkaller.appspotmail.com
Cc: Ying Xue <ying.xue@windriver.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index fb2c0d8f359f6..d27f30a9a01d8 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -319,7 +319,6 @@ static int tipc_enable_bearer(struct net *net, const char *name,
 	res = tipc_disc_create(net, b, &b->bcast_addr, &skb);
 	if (res) {
 		bearer_disable(net, b);
-		kfree(b);
 		errstr = "failed to create discoverer";
 		goto rejected;
 	}