From: Dan Carpenter Date: Wed, 23 Jan 2019 09:37:55 +0000 (+0300) Subject: drm/komeda: Off by one in komeda_fb_get_pixel_addr() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dcc9d76b6d834d06a317e27fa8242d7e009135ac;p=linux.git drm/komeda: Off by one in komeda_fb_get_pixel_addr() The > should be >= to avoid an off by one bug. Fixes: c46c24bb6b11 ("drm/komeda: Add komeda_framebuffer") Signed-off-by: Dan Carpenter Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Liviu Dudau --- diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c index 4ddd5314ca232..23ee74d422396 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c @@ -144,7 +144,7 @@ komeda_fb_get_pixel_addr(struct komeda_fb *kfb, int x, int y, int plane) const struct drm_gem_cma_object *obj; u32 plane_x, plane_y, cpp, pitch, offset; - if (plane > fb->format->num_planes) { + if (plane >= fb->format->num_planes) { DRM_DEBUG_KMS("Out of max plane num.\n"); return -EINVAL; }