From: Andy Shevchenko Date: Mon, 16 Jan 2023 14:44:46 +0000 (+0100) Subject: gpio: merrifield: Use dev_err_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dd0ccef23649d2e54aea1b317be36b2dbde0f329;p=linux.git gpio: merrifield: Use dev_err_probe() Improve error handling in the probe() function with dev_err_probe(). Signed-off-by: Andy Shevchenko --- diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c index 5c0b460fcd905..c640573439546 100644 --- a/drivers/gpio/gpio-merrifield.c +++ b/drivers/gpio/gpio-merrifield.c @@ -78,10 +78,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, const struct pci_device_id *id return retval; retval = pcim_iomap_regions(pdev, BIT(1) | BIT(0), pci_name(pdev)); - if (retval) { - dev_err(&pdev->dev, "I/O memory mapping error\n"); - return retval; - } + if (retval) + return dev_err_probe(dev, retval, "I/O memory mapping error\n"); base = pcim_iomap_table(pdev)[1];