From: Michal Wajdeczko Date: Fri, 12 Jan 2024 16:06:52 +0000 (+0100) Subject: drm/xe: Use kstrdup while creating snapshot X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ddc3c0877e16669eb61782f0fe3abc786cc426a1;p=linux.git drm/xe: Use kstrdup while creating snapshot There is no need to copy string step by step, use existing helper. Cc: Rodrigo Vivi Reviewed-by: Rodrigo Vivi Link: https://lore.kernel.org/r/20240112160652.893-1-michal.wajdeczko@intel.com Signed-off-by: Michal Wajdeczko --- diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c index e279ef6c527cd..3aaab507f37fe 100644 --- a/drivers/gpu/drm/xe/xe_hw_engine.c +++ b/drivers/gpu/drm/xe/xe_hw_engine.c @@ -749,7 +749,6 @@ struct xe_hw_engine_snapshot * xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe) { struct xe_hw_engine_snapshot *snapshot; - int len; if (!xe_hw_engine_is_valid(hwe)) return NULL; @@ -759,11 +758,7 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe) if (!snapshot) return NULL; - len = strlen(hwe->name) + 1; - snapshot->name = kzalloc(len, GFP_ATOMIC); - if (snapshot->name) - strscpy(snapshot->name, hwe->name, len); - + snapshot->name = kstrdup(hwe->name, GFP_ATOMIC); snapshot->class = hwe->class; snapshot->logical_instance = hwe->logical_instance; snapshot->forcewake.domain = hwe->domain;