From: Lee Jones Date: Mon, 13 Jul 2020 14:49:30 +0000 (+0100) Subject: pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=de4334f7da83a169b984d617af0d7eb383aef5a5;p=linux.git pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, 'struct amd_gpio_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/pinctrl-amd.c:959:36: warning: ‘amd_gpio_acpi_match’ defined but not used [-Wunused-const-variable=] 959 | static const struct acpi_device_id amd_gpio_acpi_match[] = { Signed-off-by: Lee Jones Cc: Ken Xue Cc: "Wu, Jeff" Cc: Nehal Shah Cc: Sundar S K Link: https://lore.kernel.org/r/20200713144930.1034632-26-lee.jones@linaro.org Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index c34e6a950b3f6..ccf6120311193 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -956,12 +956,14 @@ static int amd_gpio_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_ACPI static const struct acpi_device_id amd_gpio_acpi_match[] = { { "AMD0030", 0 }, { "AMDI0030", 0}, { }, }; MODULE_DEVICE_TABLE(acpi, amd_gpio_acpi_match); +#endif static struct platform_driver amd_gpio_driver = { .driver = {