From: Uwe Kleine-König Date: Sat, 24 Aug 2019 15:37:05 +0000 (+0200) Subject: pwm: sun4i: Don't update the state for the caller of pwm_apply_state() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=deb9c462f4e539cc7f8389b9855eb7a507c78e7e;p=linux.git pwm: sun4i: Don't update the state for the caller of pwm_apply_state() The pwm-sun4i driver is one of only three PWM drivers which updates the state for the caller of pwm_apply_state(). This might have surprising results if the caller reuses the values expecting them to still represent the same state. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index de78c824bbfd7..39007a7c0d835 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -192,12 +192,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm, *dty = div; *prsclr = prescaler; - div = (u64)pval * NSEC_PER_SEC * *prd; - state->period = DIV_ROUND_CLOSEST_ULL(div, clk_rate); - - div = (u64)pval * NSEC_PER_SEC * *dty; - state->duty_cycle = DIV_ROUND_CLOSEST_ULL(div, clk_rate); - return 0; }