From: Philippe Mathieu-Daudé Date: Wed, 2 Sep 2020 08:05:52 +0000 (+0200) Subject: tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS) X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=df1a312fea58bb3f83b5d7eba0946d43cb16675f;p=qemu.git tests/qtest/ahci: Improve error handling (NEGATIVE_RETURNS) Fix an error handling issue reported by Coverity: /qemu/tests/qtest/ahci-test.c: 1452 in prepare_iso() 1444 int fd = mkstemp(cdrom_path); >>> CID 1432375: Error handling issues (NEGATIVE_RETURNS) >>> "fd" is passed to a parameter that cannot be negative. 1452 ret = write(fd, patt, size); Reported-by: Coverity (CID 1432375) Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200902080552.159806-1-philmd@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c index ca4294f44f..5e1954852e 100644 --- a/tests/qtest/ahci-test.c +++ b/tests/qtest/ahci-test.c @@ -1443,6 +1443,7 @@ static int prepare_iso(size_t size, unsigned char **buf, char **name) ssize_t ret; int fd = mkstemp(cdrom_path); + g_assert(fd != -1); g_assert(buf); g_assert(name); patt = g_malloc(size);