From: Gustavo A. R. Silva <garsilva@embeddedor.com>
Date: Fri, 10 Nov 2017 22:05:45 +0000 (-0600)
Subject: tty: vt: replace _manual_ swap with swap macro in set_selection
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=df3d9a5b771fa40689bbbdf54bd575d2817fe028;p=linux.git

tty: vt: replace _manual_ swap with swap macro in set_selection

Make use of the swap macro instead of _manually_ swapping values
and remove unnecessary variable tmp.

This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index af4da95071800..7851383fbd6c7 100644
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -186,11 +186,7 @@ int set_selection(const struct tiocl_selection __user *sel, struct tty_struct *t
 	}
 
 	if (ps > pe)	/* make sel_start <= sel_end */
-	{
-		int tmp = ps;
-		ps = pe;
-		pe = tmp;
-	}
+		swap(ps, pe);
 
 	if (sel_cons != vc_cons[fg_console].d) {
 		clear_selection();