From: Bartosz Golaszewski <bartekgola@gmail.com>
Date: Fri, 9 Jun 2017 15:29:54 +0000 (+0200)
Subject: tests: improve the test names
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dfd2899dc4dbf2e7b8265a737bfbfea596402be2;p=qemu-gpiodev%2Flibgpiod.git

tests: improve the test names

Make the names of the gpiotools test cases more informative.

Signed-off-by: Bartosz Golaszewski <bartekgola@gmail.com>
---

diff --git a/tests/tests-gpiodetect.c b/tests/tests-gpiodetect.c
index 747fead..b39d551 100644
--- a/tests/tests-gpiodetect.c
+++ b/tests/tests-gpiodetect.c
@@ -12,7 +12,7 @@
 
 #include <stdio.h>
 
-static void gpiodetect_good(void)
+static void gpiodetect_simple(void)
 {
 	TEST_CLEANUP(test_free_str) char *pattern0 = NULL;
 	TEST_CLEANUP(test_free_str) char *pattern1 = NULL;
@@ -41,6 +41,6 @@ static void gpiodetect_good(void)
 	TEST_ASSERT_STR_CONTAINS(test_tool_stdout(), pattern2);
 	TEST_ASSERT_NULL(test_tool_stderr());
 }
-TEST_DEFINE(gpiodetect_good,
-	    "tools: gpiodetect - good",
+TEST_DEFINE(gpiodetect_simple,
+	    "tools: gpiodetect - simple",
 	    0, { 4, 8, 16 });
diff --git a/tests/tests-gpiofind.c b/tests/tests-gpiofind.c
index f2531c3..3a88330 100644
--- a/tests/tests-gpiofind.c
+++ b/tests/tests-gpiofind.c
@@ -10,7 +10,7 @@
 
 #include "gpiod-test.h"
 
-static void gpiofind_good(void)
+static void gpiofind_found(void)
 {
 	test_gpiotool_run("gpiofind", "gpio-mockup-B-7", (char *)NULL);
 	test_tool_wait();
@@ -21,8 +21,8 @@ static void gpiofind_good(void)
 	TEST_ASSERT_STR_EQ(test_tool_stdout(), "gpiochip1 7\n");
 	TEST_ASSERT_NULL(test_tool_stderr());
 }
-TEST_DEFINE(gpiofind_good,
-	    "tools: gpiofind - good",
+TEST_DEFINE(gpiofind_found,
+	    "tools: gpiofind - found",
 	    TEST_FLAG_NAMED_LINES, { 4, 8 });
 
 static void gpiofind_not_found(void)
diff --git a/tests/tests-gpioinfo.c b/tests/tests-gpioinfo.c
index 3837653..5264b61 100644
--- a/tests/tests-gpioinfo.c
+++ b/tests/tests-gpioinfo.c
@@ -64,5 +64,5 @@ static void gpioinfo_one_exported(void)
 	TEST_ASSERT_REGEX_MATCH(test_tool_stdout(), ptrn);
 }
 TEST_DEFINE(gpioinfo_one_exported,
-	    "tools: gpioinfo - one exported",
+	    "tools: gpioinfo - exported line",
 	    0, { 4, 8 });