From: Anthony Liguori <aliguori@us.ibm.com>
Date: Sun, 1 Apr 2012 19:18:30 +0000 (-0500)
Subject: serial: clear LSR.TEMT when populating the TSR
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dfe844c9043815497b6472bfaf470b0f8d2e7312;p=qemu.git

serial: clear LSR.TEMT when populating the TSR

We never actually clear the TEMT (transmit sending register empty) flag when
populating the TSR.  We set the flag, but since it's never cleared, setting it
is sort of pointless..

I found this with a unit test case.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/hw/serial.c b/hw/serial.c
index b499bca659..a421d1e7bc 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -332,6 +332,7 @@ static void serial_xmit(void *opaque)
         } else {
             s->tsr = s->thr;
             s->lsr |= UART_LSR_THRE;
+            s->lsr &= ~UART_LSR_TEMT;
         }
     }