From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: Wed, 6 Dec 2023 17:20:19 +0000 (+0200)
Subject: media: adv7183: Don't set format in sub-device state
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=dff1eebf2be36278d2669504ad9249f1d7505bc0;p=linux.git

media: adv7183: Don't set format in sub-device state

For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.

Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---

diff --git a/drivers/media/i2c/adv7183.c b/drivers/media/i2c/adv7183.c
index bcb99ba9a2720..2a2cace4a1538 100644
--- a/drivers/media/i2c/adv7183.c
+++ b/drivers/media/i2c/adv7183.c
@@ -442,8 +442,6 @@ static int adv7183_set_fmt(struct v4l2_subdev *sd,
 	}
 	if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
 		decoder->fmt = *fmt;
-	else
-		*v4l2_subdev_state_get_format(sd_state, 0) = *fmt;
 	return 0;
 }