From: Michał Mirosław Date: Thu, 27 Oct 2022 00:06:16 +0000 (+0200) Subject: fbdev/core: Avoid uninitialized read in aperture_remove_conflicting_pci_device() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e0ba1a39b8dfe4f005bebdd85daa89e7382e26b7;p=linux.git fbdev/core: Avoid uninitialized read in aperture_remove_conflicting_pci_device() Return on error directly from the BAR-iterating loop instead of break+return. This is actually a cosmetic fix, since it would be highly unusual to have this called for a PCI device without any memory BARs. Fixes: 9d69ef183815 ("fbdev/core: Remove remove_conflicting_pci_framebuffers()") Signed-off-by: Michał Mirosław Signed-off-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/e75323732bedc46d613d72ecb40f97e3bc75eea8.1666829073.git.mirq-linux@rere.qmqm.pl --- diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c index 9e6bcc03a1a4a..41e77de1ea82c 100644 --- a/drivers/video/aperture.c +++ b/drivers/video/aperture.c @@ -340,12 +340,9 @@ int aperture_remove_conflicting_pci_devices(struct pci_dev *pdev, const char *na size = pci_resource_len(pdev, bar); ret = aperture_remove_conflicting_devices(base, size, primary, name); if (ret) - break; + return ret; } - if (ret) - return ret; - /* * WARNING: Apparently we must kick fbdev drivers before vgacon, * otherwise the vga fbdev driver falls over.