From: Logan Gunthorpe <logang@deltatee.com>
Date: Wed, 23 Oct 2019 16:35:39 +0000 (-0600)
Subject: nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e0bace71779d602e419a2f3b35f3bff2cfc638a3;p=linux.git

nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()

None of the other transports check data_len which is verified
in core code. The function should instead check that the sgl length
is non-zero.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
index d535080b781f9..1e2d92f818ad8 100644
--- a/drivers/nvme/target/tcp.c
+++ b/drivers/nvme/target/tcp.c
@@ -320,7 +320,7 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd)
 	struct nvme_sgl_desc *sgl = &cmd->req.cmd->common.dptr.sgl;
 	u32 len = le32_to_cpu(sgl->length);
 
-	if (!cmd->req.data_len)
+	if (!len)
 		return 0;
 
 	if (sgl->type == ((NVME_SGL_FMT_DATA_DESC << 4) |