From: Jan Kara Date: Fri, 16 Jun 2023 16:50:52 +0000 (+0200) Subject: ext4: avoid starting transaction on read-only fs in ext4_quota_off() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e0e985f3f8941438a66ab8abb94cb011b9fb39a7;p=linux.git ext4: avoid starting transaction on read-only fs in ext4_quota_off() When the filesystem gets first remounted read-only and then unmounted, ext4_quota_off() will try to start a transaction (and fail) on read-only filesystem to cleanup inode flags for legacy quota files. Just bail before trying to start a transaction instead since that is going to issue a warning. Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20230616165109.21695-6-jack@suse.cz Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 20a8e64da4ac7..a9a7c38c74423 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -7072,6 +7072,13 @@ static int ext4_quota_off(struct super_block *sb, int type) err = dquot_quota_off(sb, type); if (err || ext4_has_feature_quota(sb)) goto out_put; + /* + * When the filesystem was remounted read-only first, we cannot cleanup + * inode flags here. Bad luck but people should be using QUOTA feature + * these days anyway. + */ + if (sb_rdonly(sb)) + goto out_put; inode_lock(inode); /*