From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 14 Jan 2021 17:57:17 +0000 (+0100)
Subject: tty: vcc: Drop unnecessary if block
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e1d830ab32808dcb63861b63d44d96768f9cf7d3;p=linux.git

tty: vcc: Drop unnecessary if block

If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c
index a4388a8d6bc7a..e2d6205f83ce1 100644
--- a/drivers/tty/vcc.c
+++ b/drivers/tty/vcc.c
@@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev)
 {
 	struct vcc_port *port = dev_get_drvdata(&vdev->dev);
 
-	if (!port)
-		return -ENODEV;
-
 	del_timer_sync(&port->rx_timer);
 	del_timer_sync(&port->tx_timer);