From: Pedro Tammela <pctammela@mojatatu.com>
Date: Fri, 28 Jul 2023 15:35:37 +0000 (-0300)
Subject: net/sched: sch_qfq: warn about class in use while deleting
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e20e75017c5a3dbc4a3cc505d8ad57487b500bbb;p=linux.git

net/sched: sch_qfq: warn about class in use while deleting

Add extack to warn that delete was rejected because
the class is still in use

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index 7addc15f01b5c..1a25752f1a9a6 100644
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -543,8 +543,10 @@ static int qfq_delete_class(struct Qdisc *sch, unsigned long arg,
 	struct qfq_sched *q = qdisc_priv(sch);
 	struct qfq_class *cl = (struct qfq_class *)arg;
 
-	if (qdisc_class_in_use(&cl->common))
+	if (qdisc_class_in_use(&cl->common)) {
+		NL_SET_ERR_MSG_MOD(extack, "QFQ class in use");
 		return -EBUSY;
+	}
 
 	sch_tree_lock(sch);