From: Christoph Hellwig <hch@lst.de>
Date: Tue, 29 Jan 2019 18:13:08 +0000 (+0100)
Subject: parisc/dino: use container_of in DINO_DEV
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e2fcabe0ebe0b343b9de53ed0a7a7f2f86eb9863;p=linux.git

parisc/dino: use container_of in DINO_DEV

Use the type safe container_of macros instead of a blind cast in
DINO_DEV, and turn the macro into an inline function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Helge Deller <deller@gmx.de>
---

diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c
index 6f348c75687c4..846b59d159999 100644
--- a/drivers/parisc/dino.c
+++ b/drivers/parisc/dino.c
@@ -154,12 +154,10 @@ struct dino_device
 #endif
 };
 
-/* Looks nice and keeps the compiler happy */
-#define DINO_DEV(d) ({				\
-	void *__pdata = d;			\
-	BUG_ON(!__pdata);			\
-	(struct dino_device *)__pdata; })
-
+static inline struct dino_device *DINO_DEV(struct pci_hba_data *hba)
+{
+	return container_of(hba, struct dino_device, hba);
+}
 
 /*
  * Dino Configuration Space Accessor Functions