From: Uwe Kleine-König Date: Fri, 13 Oct 2023 13:24:42 +0000 (+0200) Subject: chardev: Simplify usage of try_module_get() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e311ba29a552194ece6c1579fe434bdad550bfac;p=linux.git chardev: Simplify usage of try_module_get() try_module_get(NULL) is true, so there is no need to check owner being NULL. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231013132441.1406200-2-u.kleine-koenig@pengutronix.de Signed-off-by: Christian Brauner --- diff --git a/fs/char_dev.c b/fs/char_dev.c index 950b6919fb872..6ba032442b39d 100644 --- a/fs/char_dev.c +++ b/fs/char_dev.c @@ -350,7 +350,7 @@ static struct kobject *cdev_get(struct cdev *p) struct module *owner = p->owner; struct kobject *kobj; - if (owner && !try_module_get(owner)) + if (!try_module_get(owner)) return NULL; kobj = kobject_get_unless_zero(&p->kobj); if (!kobj)