From: NeilBrown Date: Mon, 7 Jan 2019 06:53:52 +0000 (+1100) Subject: SUNRPC: remove pointless test in unx_match() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e3735c89985415f4fb509c67963e3d05969fbdb1;p=linux.git SUNRPC: remove pointless test in unx_match() As reported by Dan Carpenter, this test for acred->cred being set is inconsistent with the dereference of the pointer a few lines earlier. An 'auth_cred' *always* has ->cred set - every place that creates one initializes this field, often as the first thing done. So remove this test. Reported-by: Dan Carpenter Signed-off-by: NeilBrown Signed-off-by: Trond Myklebust --- diff --git a/net/sunrpc/auth_unix.c b/net/sunrpc/auth_unix.c index 387f6b3ffbeaf..770e338a9b117 100644 --- a/net/sunrpc/auth_unix.c +++ b/net/sunrpc/auth_unix.c @@ -87,7 +87,7 @@ unx_match(struct auth_cred *acred, struct rpc_cred *cred, int flags) if (!uid_eq(cred->cr_cred->fsuid, acred->cred->fsuid) || !gid_eq(cred->cr_cred->fsgid, acred->cred->fsgid)) return 0; - if (acred->cred && acred->cred->group_info != NULL) + if (acred->cred->group_info != NULL) groups = acred->cred->group_info->ngroups; if (groups > UNX_NGROUPS) groups = UNX_NGROUPS;