From: Christian Lütke-Stetzkamp Date: Wed, 25 Apr 2018 06:43:18 +0000 (+0200) Subject: staging: mt7621-mmc: Fix calculation typo in msdc_init_gpd_bd X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e396de684ebea31bde476423edcb087432f46729;p=linux.git staging: mt7621-mmc: Fix calculation typo in msdc_init_gpd_bd When refactoring the function msdc_init_gpd_bd, an error in the calculation of the bd.next address was introduced. The offset has to be added to the base address, not multiplied. Fixes: 8f2395586cf0 ("staging: mt7621-mmc: Refactor msdc_init_gpd_bd") Reported-by: NeilBrown Signed-off-by: Christian Lütke-Stetzkamp Tested-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index ae70f9d0b3463..a003f83240889 100644 --- a/drivers/staging/mt7621-mmc/sd.c +++ b/drivers/staging/mt7621-mmc/sd.c @@ -2505,7 +2505,7 @@ static void msdc_init_gpd_bd(struct msdc_host *host, struct msdc_dma *dma) memset(bd, 0, sizeof(struct bd) * MAX_BD_NUM); for (i = 0; i < (MAX_BD_NUM - 1); i++) - bd[i].next = (void *)(dma->bd_addr * sizeof(*bd) * (i + 1)); + bd[i].next = (void *)(dma->bd_addr + sizeof(*bd) * (i + 1)); } static int msdc_drv_probe(struct platform_device *pdev)