From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 28 Jun 2021 13:58:22 +0000 (+0100)
Subject: target/arm: Use dup_const() instead of bitfield_replicate()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e4667a5b5e71d83e3e2af70e7dba4bfab8892829;p=qemu.git

target/arm: Use dup_const() instead of bitfield_replicate()

Use dup_const() instead of bitfield_replicate() in
disas_simd_mod_imm().

(We can't replace the other use of bitfield_replicate() in this file,
in logic_imm_decode_wmask(), because that location needs to handle 2
and 4 bit elements, which dup_const() cannot.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20210628135835.6690-6-peter.maydell@linaro.org
---

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 66781f71cb..e81cc20d04 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -8212,7 +8212,7 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn)
         /* FMOV (vector, immediate) - half-precision */
         imm = vfp_expand_imm(MO_16, abcdefgh);
         /* now duplicate across the lanes */
-        imm = bitfield_replicate(imm, 16);
+        imm = dup_const(MO_16, imm);
     } else {
         imm = asimd_imm_const(abcdefgh, cmode, is_neg);
     }