From: Filipe Manana Date: Thu, 30 Mar 2023 14:39:02 +0000 (+0100) Subject: btrfs: make btrfs_block_rsv_full() check more boolean when starting transaction X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e4773b57b8949cec8743445e7877315c012fe5ca;p=linux.git btrfs: make btrfs_block_rsv_full() check more boolean when starting transaction When starting a transaction we are comparing the result of a call to btrfs_block_rsv_full() with 0, but the function returns a boolean. While in practice it is not incorrect, as 0 is equivalent to false, it makes it a bit odd and less readable. So update the check to not compare against 0 and instead use the logical not (!) operator. Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index c8e503e5db4cd..c497886d30e67 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -607,7 +607,7 @@ start_transaction(struct btrfs_root *root, unsigned int num_items, */ num_bytes = btrfs_calc_insert_metadata_size(fs_info, num_items); if (flush == BTRFS_RESERVE_FLUSH_ALL && - btrfs_block_rsv_full(delayed_refs_rsv) == 0) { + !btrfs_block_rsv_full(delayed_refs_rsv)) { delayed_refs_bytes = num_bytes; num_bytes <<= 1; }