From: Daniel P. Berrange Date: Tue, 22 Dec 2015 15:43:42 +0000 (+0000) Subject: io: bind to loopback IP addrs in test suite X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e4d2edc9d0c58de421eb349871e90b67edec0b9c;p=qemu.git io: bind to loopback IP addrs in test suite The test suite currently binds to 0.0.0.0 or ::, which covers all interfaces of the machine. It is bad practice for test suite to open publically accessible ports on a machine, so switch to use loopback addrs 127.0.0.1 or ::1. Reported-by: Peter Maydell Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c index 194d043878..e76d54c3f8 100644 --- a/tests/test-io-channel-socket.c +++ b/tests/test-io-channel-socket.c @@ -261,7 +261,7 @@ static void test_io_channel_ipv4(bool async) listen_addr->type = SOCKET_ADDRESS_KIND_INET; listen_addr->u.inet = g_new0(InetSocketAddress, 1); - listen_addr->u.inet->host = g_strdup("0.0.0.0"); + listen_addr->u.inet->host = g_strdup("127.0.0.1"); listen_addr->u.inet->port = NULL; /* Auto-select */ connect_addr->type = SOCKET_ADDRESS_KIND_INET; @@ -295,7 +295,7 @@ static void test_io_channel_ipv6(bool async) listen_addr->type = SOCKET_ADDRESS_KIND_INET; listen_addr->u.inet = g_new0(InetSocketAddress, 1); - listen_addr->u.inet->host = g_strdup("::"); + listen_addr->u.inet->host = g_strdup("::1"); listen_addr->u.inet->port = NULL; /* Auto-select */ connect_addr->type = SOCKET_ADDRESS_KIND_INET;