From: Bandan Das <bsd@redhat.com>
Date: Wed, 3 Jun 2015 22:38:10 +0000 (-0400)
Subject: monitor: Fix failure path for "S" argument
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e549d2aaeba1cfac207c9a9675cc203e6372a22e;p=qemu.git

monitor: Fix failure path for "S" argument

Since the "S" argument type is only used with the "?" flag,
the bug can't bite.

Signed-off-by: Bandan Das <bsd@redhat.com>
Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---

diff --git a/monitor.c b/monitor.c
index 4c7faf9716..8b1dbf85c1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4016,7 +4016,7 @@ static QDict *monitor_parse_arguments(Monitor *mon,
                 if (len <= 0) {
                     monitor_printf(mon, "%s: string expected\n",
                                    cmd->name);
-                    break;
+                    goto fail;
                 }
                 qdict_put(qdict, key, qstring_from_str(p));
                 p += len;