From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Fri, 14 Jun 2024 13:17:55 +0000 (+0200)
Subject: hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30)
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e55cbe727b07f1c39f57c1af842ff2fca9bc2d4a;p=qemu.git

hw/sd/sdcard: Send WRITE_PROT bits MSB first (CMD30)

Per sections 3.6.1 (SD Bus Protocol) and 7.3.2 (Responses):

  In the CMD line the Most Significant Bit is transmitted first.

Use the stl_be_p() helper to store the value in big-endian.

Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240628070216.92609-8-philmd@linaro.org>
---

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index b5d002e6d7..1e9530f9ae 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1508,7 +1508,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
             }
 
             sd->state = sd_sendingdata_state;
-            *(uint32_t *) sd->data = sd_wpbits(sd, req.arg);
+            stl_be_p(sd->data, sd_wpbits(sd, req.arg));
             sd->data_start = addr;
             sd->data_offset = 0;
             return sd_r1;