From: Alberto Faria Date: Tue, 8 Nov 2022 14:44:33 +0000 (+0000) Subject: block/blkio: Set BlockDriver::has_variable_length to false X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e56b0c66310feab14a14dd6a24fd58dae178e059;p=qemu.git block/blkio: Set BlockDriver::has_variable_length to false Setting it to true can cause the device size to be queried from libblkio in otherwise fast paths, degrading performance. Set it to false and require users to refresh the device size explicitly instead. Fixes: 4c8f4fda0504 ("block/blkio: Tolerate device size changes") Suggested-by: Kevin Wolf Signed-off-by: Alberto Faria Message-Id: <20221108144433.1334074-1-afaria@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- diff --git a/block/blkio.c b/block/blkio.c index 620fab28a7..5eae3adfaf 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -993,7 +993,6 @@ static void blkio_refresh_limits(BlockDriverState *bs, Error **errp) { \ .format_name = name, \ .protocol_name = name, \ - .has_variable_length = true, \ .instance_size = sizeof(BDRVBlkioState), \ .bdrv_file_open = blkio_file_open, \ .bdrv_close = blkio_close, \