From: Heiner Kallweit Date: Sun, 14 Apr 2019 09:48:39 +0000 (+0200) Subject: r8169: change irq handler to always trigger NAPI polling X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e62b2fd5d3b4c5c958cf88b92f31960750d88dc5;p=linux.git r8169: change irq handler to always trigger NAPI polling This check isn't really needed and we can simplify the code and save some CPU cycles by removing it. Only in case of an error none of these bits are set, and calling the NAPI callback doesn't hurt in this case. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 68caa26f0c3ee..efaea1a0ad64f 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6380,10 +6380,8 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) set_bit(RTL_FLAG_TASK_RESET_PENDING, tp->wk.flags); } - if (status & (RTL_EVENT_NAPI | LinkChg)) { - rtl_irq_disable(tp); - napi_schedule_irqoff(&tp->napi); - } + rtl_irq_disable(tp); + napi_schedule_irqoff(&tp->napi); out: rtl_ack_events(tp, status);