From: Michael S. Tsirkin <mst@redhat.com>
Date: Thu, 10 Dec 2009 13:42:56 +0000 (+0200)
Subject: ne2000: switch to symbolic names for pci registers
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e6c4cfd50327d730e4c0cfd6ece43e7b59224acd;p=qemu.git

ne2000: switch to symbolic names for pci registers

No functional changes. I verified that the generated binary
does not change.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Juan Quintela <quintela@redhat.com>
Acked-by: Glauber Costa <glommer@gmail.com>
---

diff --git a/hw/ne2000.c b/hw/ne2000.c
index d1416cfb7f..78fe14fe1c 100644
--- a/hw/ne2000.c
+++ b/hw/ne2000.c
@@ -724,7 +724,8 @@ static int pci_ne2000_init(PCIDevice *pci_dev)
     pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8029);
     pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
     pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type
-    pci_conf[0x3d] = 1; // interrupt pin 0
+    /* TODO: RST# value should be 0. PCI spec 6.2.4 */
+    pci_conf[PCI_INTERRUPT_PIN] = 1; // interrupt pin 0
 
     pci_register_bar(&d->dev, 0, 0x100,
                            PCI_BASE_ADDRESS_SPACE_IO, ne2000_map);