From: Chengguang Xu <cgxu519@mykernel.net>
Date: Tue, 5 Nov 2019 04:51:00 +0000 (+0800)
Subject: ext2: check err when partial != NULL
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e705f4b8aa27a59f8933e8f384e9752f052c469c;p=linux.git

ext2: check err when partial != NULL

Check err when partial == NULL is meaningless because
partial == NULL means getting branch successfully without
error.

CC: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191105045100.7104-1-cgxu519@mykernel.net
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 7004ce581a328..a16c53655e770 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -701,10 +701,13 @@ static int ext2_get_blocks(struct inode *inode,
 		if (!partial) {
 			count++;
 			mutex_unlock(&ei->truncate_mutex);
-			if (err)
-				goto cleanup;
 			goto got_it;
 		}
+
+		if (err) {
+			mutex_unlock(&ei->truncate_mutex);
+			goto cleanup;
+		}
 	}
 
 	/*