From: Vasily Averin <vvs@virtuozzo.com>
Date: Tue, 2 Jun 2020 12:55:26 +0000 (+0300)
Subject: net_failover: fixed rollback in net_failover_open()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e8224bfe77293494626f6eec1884fee7b87d0ced;p=linux.git

net_failover: fixed rollback in net_failover_open()

found by smatch:
drivers/net/net_failover.c:65 net_failover_open() error:
 we previously assumed 'primary_dev' could be null (see line 43)

Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index b16a1221d19b9..fb182bec8f062 100644
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -61,7 +61,8 @@ static int net_failover_open(struct net_device *dev)
 	return 0;
 
 err_standby_open:
-	dev_close(primary_dev);
+	if (primary_dev)
+		dev_close(primary_dev);
 err_primary_open:
 	netif_tx_disable(dev);
 	return err;