From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 18 Jul 2017 10:57:38 +0000 (+0200)
Subject: migration: Add TODO comments on duplication of QAPI_CLONE()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e87fae4c488ff8a10b921311a63f16b94031c611;p=qemu.git

migration: Add TODO comments on duplication of QAPI_CLONE()

qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
effectively duplicate QAPI_CLONE() inline.  Add suitable TODO
comments.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/migration/migration.c b/migration/migration.c
index 88b9277e68..6b4d17fbb5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -433,6 +433,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
     MigrationParameters *params;
     MigrationState *s = migrate_get_current();
 
+    /* TODO use QAPI_CLONE() instead of duplicating it inline */
     params = g_malloc0(sizeof(*params));
     params->has_compress_level = true;
     params->compress_level = s->parameters.compress_level;
@@ -745,6 +746,8 @@ static void migrate_params_apply(MigrationParameters *params)
 {
     MigrationState *s = migrate_get_current();
 
+    /* TODO use QAPI_CLONE() instead of duplicating it inline */
+
     if (params->has_compress_level) {
         s->parameters.compress_level = params->compress_level;
     }