From: Martin Kaiser Date: Tue, 6 Apr 2021 20:48:25 +0000 (+0200) Subject: staging: rtl8188eu: clean up usb_read32 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e8f44d356e6b6a83b907184852e8d4ce1384fd59;p=linux.git staging: rtl8188eu: clean up usb_read32 Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20210406204829.18130-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c index 915bf86237b01..beab5343fda81 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c @@ -316,14 +316,10 @@ u16 usb_read16(struct adapter *adapter, u32 addr) u32 usb_read32(struct adapter *adapter, u32 addr) { - u16 wvalue; - u16 len; + u16 wvalue = (u16)(addr & 0xffff); __le32 data; - wvalue = (u16)(addr & 0x0000ffff); - len = 4; - - usbctrl_vendorreq(adapter, wvalue, &data, len, REALTEK_USB_VENQT_READ); + usbctrl_vendorreq(adapter, wvalue, &data, 4, REALTEK_USB_VENQT_READ); return le32_to_cpu(data); }