From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: Thu, 17 Jun 2021 11:53:22 +0000 (+0200)
Subject: hw/display/sm501: Simplify sm501_i2c_write() logic
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e91113d0f9481c072f74e8390399e11b93856844;p=qemu.git

hw/display/sm501: Simplify sm501_i2c_write() logic

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 8789722ef2..f276276f7f 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value,
                 int res = i2c_start_transfer(s->i2c_bus,
                                              s->i2c_addr >> 1,
                                              s->i2c_addr & 1);
-                s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
-                if (!res) {
+                if (res) {
+                    s->i2c_status |= SM501_I2C_STATUS_ERROR;
+                } else {
                     int i;
                     for (i = 0; i <= s->i2c_byte_count; i++) {
                         res = i2c_send_recv(s->i2c_bus, &s->i2c_data[i],