From: Dan Carpenter Date: Tue, 7 Apr 2020 12:21:49 +0000 (+0300) Subject: ipmi: kcs: Fix aspeed_kcs_probe_of_v1() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e96387677c2a4a35a0c8b16cd517696a04050062;p=linux.git ipmi: kcs: Fix aspeed_kcs_probe_of_v1() This needs to return the newly allocated struct but instead it returns zero which leads to an immediate Oops in the caller. Fixes: 09f5f680707e ("ipmi: kcs: aspeed: Implement v2 bindings") Signed-off-by: Dan Carpenter Message-Id: <20200407122149.GA100026@mwanda> Signed-off-by: Corey Minyard --- diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 9422d55a0476a..a140203c079ba 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -271,7 +271,7 @@ static struct kcs_bmc *aspeed_kcs_probe_of_v1(struct platform_device *pdev) kcs->ioreg = ast_kcs_bmc_ioregs[channel - 1]; aspeed_kcs_set_address(kcs, slave); - return 0; + return kcs; } static int aspeed_kcs_calculate_channel(const struct kcs_ioreg *regs)