From: Geert Uytterhoeven Date: Fri, 6 Jul 2018 08:49:35 +0000 (+0200) Subject: block: Add default switch case to blk_pm_allow_request() to kill warning X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e9a83853302b339e63dea4072f6210e5a88ab4bb;p=linux.git block: Add default switch case to blk_pm_allow_request() to kill warning With gcc 4.9.0 and 7.3.0: block/blk-core.c: In function 'blk_pm_allow_request': block/blk-core.c:2747:2: warning: enumeration value 'RPM_ACTIVE' not handled in switch [-Wswitch] switch (rq->q->rpm_status) { ^ Convert the return statement below the switch() block into a default case to fix this. Fixes: e4f36b249b4d4e75 ("block: fix peeking requests during PM") Signed-off-by: Geert Uytterhoeven Reviewed-by: Christoph Hellwig Signed-off-by: Jens Axboe --- diff --git a/block/blk-core.c b/block/blk-core.c index 687d7732f23a0..c4b57d8806fe1 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2753,9 +2753,9 @@ static bool blk_pm_allow_request(struct request *rq) return rq->rq_flags & RQF_PM; case RPM_SUSPENDED: return false; + default: + return true; } - - return true; } #else static bool blk_pm_allow_request(struct request *rq)