From: Amit Shah <amit.shah@redhat.com>
Date: Thu, 3 Mar 2011 07:58:55 +0000 (+0530)
Subject: virtio-serial-bus: Simplify handle_output() function
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e9b382b0170ee045295f2ff0ce1009a01a11eb1f;p=qemu.git

virtio-serial-bus: Simplify handle_output() function

There's no code change, just re-arrangement to simplify the function
after recent modifications.

Reported-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---

diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index c6feb4316b..a82fbe9ba4 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -442,25 +442,19 @@ static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
 {
     VirtIOSerial *vser;
     VirtIOSerialPort *port;
-    bool discard;
 
     vser = DO_UPCAST(VirtIOSerial, vdev, vdev);
     port = find_port_by_vq(vser, vq);
 
-    discard = false;
     if (!port || !port->host_connected || !port->info->have_data) {
-        discard = true;
-    }
-
-    if (discard) {
         discard_vq_data(vq, vdev);
         return;
     }
-    if (port->throttled) {
+
+    if (!port->throttled) {
+        do_flush_queued_data(port, vq, vdev);
         return;
     }
-
-    do_flush_queued_data(port, vq, vdev);
 }
 
 static void handle_input(VirtIODevice *vdev, VirtQueue *vq)