From: Ian Wienand Date: Wed, 6 Apr 2022 09:36:36 +0000 (+1000) Subject: net: ethernet: set default assignment identifier to NET_NAME_ENUM X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=e9f656b7a21408866ba04c112ccbac73885529bd;p=linux.git net: ethernet: set default assignment identifier to NET_NAME_ENUM As noted in the original commit 685343fc3ba6 ("net: add name_assign_type netdev attribute") ... when the kernel has given the interface a name using global device enumeration based on order of discovery (ethX, wlanY, etc) ... are labelled NET_NAME_ENUM. That describes this case, so set the default for the devices here to NET_NAME_ENUM. Current popular network setup tools like systemd use this only to warn if you're setting static settings on interfaces that might change, so it is expected this only leads to better user information, but not changing of interfaces, etc. Signed-off-by: Ian Wienand Link: https://lore.kernel.org/r/20220406093635.1601506-1-iwienand@redhat.com Signed-off-by: Jakub Kicinski --- diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index ebcc812735a4c..62b89d6f54fd2 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c @@ -391,7 +391,7 @@ EXPORT_SYMBOL(ether_setup); struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs, unsigned int rxqs) { - return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_UNKNOWN, + return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_ENUM, ether_setup, txqs, rxqs); } EXPORT_SYMBOL(alloc_etherdev_mqs);