From: Colin Ian King Date: Thu, 6 Aug 2020 22:35:34 +0000 (-0700) Subject: Input: sentelic - fix error return when fsp_reg_write fails X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ea38f06e0291986eb93beb6d61fd413607a30ca4;p=linux.git Input: sentelic - fix error return when fsp_reg_write fails Currently when the call to fsp_reg_write fails -EIO is not being returned because the count is being returned instead of the return value in retval. Fix this by returning the value in retval instead of count. Addresses-Coverity: ("Unused value") Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20200603141218.131663-1-colin.king@canonical.com Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c index 9f7ecc72093a6..2716d2ba386a1 100644 --- a/drivers/input/mouse/sentelic.c +++ b/drivers/input/mouse/sentelic.c @@ -441,7 +441,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data, fsp_reg_write_enable(psmouse, false); - return count; + return retval; } PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg);