From: Ohad Sharabi <osharabi@habana.ai>
Date: Mon, 3 May 2021 06:44:22 +0000 (+0300)
Subject: habanalabs: avoid using uninitialized pointer
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ea7d5e7b102bf0bd41eef1faa6b2337e45791a62;p=linux.git

habanalabs: avoid using uninitialized pointer

When attempting to read FW component's version we should break if input
FW component is invalid in order to avoid using uninitialized
destination pointer.

Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---

diff --git a/drivers/misc/habanalabs/common/firmware_if.c b/drivers/misc/habanalabs/common/firmware_if.c
index 03e26a1fd9c16..e0fe2d5d4c577 100644
--- a/drivers/misc/habanalabs/common/firmware_if.c
+++ b/drivers/misc/habanalabs/common/firmware_if.c
@@ -1566,6 +1566,7 @@ static void hl_fw_dynamic_read_device_fw_version(struct hl_device *hdev,
 		break;
 	default:
 		dev_warn(hdev->dev, "Undefined FW component: %d\n", fwc);
+		return;
 	}
 
 	strscpy(dest, fw_version, VERSION_MAX_LEN);