From: Namjae Jeon <linkinjeon@kernel.org>
Date: Tue, 2 May 2023 23:51:51 +0000 (+0900)
Subject: ksmbd: call rcu_barrier() in ksmbd_server_exit()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=eb307d09fe15844fdaebeb8cc8c9b9e925430aa5;p=linux.git

ksmbd: call rcu_barrier() in ksmbd_server_exit()

racy issue is triggered the bug by racing between closing a connection
and rmmod. In ksmbd, rcu_barrier() is not called at module unload time,
so nothing prevents ksmbd from getting unloaded while it still has RCU
callbacks pending. It leads to trigger unintended execution of kernel
code locally and use to defeat protections such as Kernel Lockdown

Cc: stable@vger.kernel.org
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-20477
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
index 2ebf6985a88d6..f9b2e0f19b03b 100644
--- a/fs/ksmbd/server.c
+++ b/fs/ksmbd/server.c
@@ -606,6 +606,7 @@ err_unregister:
 static void __exit ksmbd_server_exit(void)
 {
 	ksmbd_server_shutdown();
+	rcu_barrier();
 	ksmbd_release_inode_hash();
 }