From: Dan Carpenter Date: Wed, 25 Sep 2019 11:01:28 +0000 (+0300) Subject: power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=eb368de6de32925c65a97c1e929a31cae2155aee;p=linux.git power: supply: sbs-battery: Fix a signedness bug in sbs_get_battery_capacity() The "mode" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: 51d075660457 ("bq20z75: Add support for charge properties") Signed-off-by: Dan Carpenter Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index c01599ecb9c8a..6acd242eed488 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -556,7 +556,7 @@ static int sbs_get_battery_capacity(struct i2c_client *client, mode = CAPACITY_MODE_AMPS; mode = sbs_set_capacity_mode(client, mode); - if (mode < 0) + if ((int)mode < 0) return mode; ret = sbs_read_word_data(client, sbs_data[reg_offset].addr);