From: Peter Zijlstra <peterz@infradead.org>
Date: Fri, 21 Oct 2022 11:47:29 +0000 (+0200)
Subject: mm: Remove pointless barrier() after pmdp_get_lockless()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=eb780dcae02d5a71e6979aa7b8c708dea8597adf;p=linux.git

mm: Remove pointless barrier() after pmdp_get_lockless()

pmdp_get_lockless() should itself imply any ordering required.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221022114425.298833095%40infradead.org
---

diff --git a/mm/hmm.c b/mm/hmm.c
index 39cf50de76d78..601a99ce3c84d 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -362,7 +362,6 @@ again:
 		 * values.
 		 */
 		pmd = pmdp_get_lockless(pmdp);
-		barrier();
 		if (!pmd_devmap(pmd) && !pmd_trans_huge(pmd))
 			goto again;
 
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 88ef873b2d83e..4936a88bb26a7 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4041,9 +4041,6 @@ restart:
 	for (i = pmd_index(start), addr = start; addr != end; i++, addr = next) {
 		pmd_t val = pmdp_get_lockless(pmd + i);
 
-		/* for pmdp_get_lockless() */
-		barrier();
-
 		next = pmd_addr_end(addr, end);
 
 		if (!pmd_present(val) || is_huge_zero_pmd(val)) {