From: Frank Rowand <frowand.list@gmail.com>
Date: Mon, 13 Feb 2023 18:57:01 +0000 (-0600)
Subject: of: add consistency check to of_node_release()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ec0b7e24d566a843e3cfba21a6471170fdb0f810;p=linux.git

of: add consistency check to of_node_release()

Add an additional consistency check to of_node_release(), which is
called when the reference count of a devicetree node is decremented
to zero.  The node's children should have been deleted before the
node is deleted so check that no children exist.

Signed-off-by: Frank Rowand <frowand.list@gmail.com>
Link: https://lore.kernel.org/r/20230213185702.395776-7-frowand.list@gmail.com
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
index dbcbc41f34651..657a65006056b 100644
--- a/drivers/of/dynamic.c
+++ b/drivers/of/dynamic.c
@@ -377,6 +377,10 @@ void of_node_release(struct kobject *kobj)
 			       __func__, node);
 	}
 
+	if (node->child)
+		pr_err("ERROR: %s() unexpected children for %pOF/%s\n",
+			__func__, node->parent, node->full_name);
+
 	property_list_free(node->properties);
 	property_list_free(node->deadprops);
 	fwnode_links_purge(of_fwnode_handle(node));