From: Johan Hovold Date: Thu, 22 Jun 2023 07:51:50 +0000 (+0200) Subject: dmaengine: mediatek: drop bogus pm_runtime_set_active() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ecc3cfc31f33c88cb9fa8fd1fcfc8a86e4b7b18b;p=linux.git dmaengine: mediatek: drop bogus pm_runtime_set_active() The runtime PM state must be updated while runtime PM is disabled for the change to take effect. Drop the bogus pm_runtime_set_active() which left the PM state set to suspended (as it should be or the clock would not be enabled when the device is resumed). Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20230622075150.885-1-johan+linaro@kernel.org Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c index a1517ef1f4a01..92864c9371a31 100644 --- a/drivers/dma/mediatek/mtk-uart-apdma.c +++ b/drivers/dma/mediatek/mtk-uart-apdma.c @@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev) } pm_runtime_enable(&pdev->dev); - pm_runtime_set_active(&pdev->dev); rc = dma_async_device_register(&mtkd->ddev); if (rc)