From: Igor Mammedov <imammedo@redhat.com>
Date: Fri, 26 Feb 2016 13:59:27 +0000 (+0100)
Subject: pc: acpi: clarify why possible LAPIC entries must be present in MADT
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ed2ef10c0ce2feed9647b9f5c3df624078dd2dd0;p=qemu.git

pc: acpi: clarify why possible LAPIC entries must be present in MADT

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 8736917f0b..0a5acb3828 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -360,6 +360,12 @@ build_madt(GArray *table_data, GArray *linker, PCMachineState *pcms)
         if (apic_ids->cpus[i].cpu != NULL) {
             apic->flags = cpu_to_le32(1);
         } else {
+            /* ACPI spec says that LAPIC entry for non present
+             * CPU may be omitted from MADT or it must be marked
+             * as disabled. However omitting non present CPU from
+             * MADT breaks hotplug on linux. So possible CPUs
+             * should be put in MADT but kept disabled.
+             */
             apic->flags = cpu_to_le32(0);
         }
     }