From: Kent Overstreet <kent.overstreet@gmail.com>
Date: Sun, 25 Jul 2021 00:20:02 +0000 (-0400)
Subject: bcachefs: Fix a btree iterator leak
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ed5580b43b083a96fe2cbcf6b1cfe340fa52fca2;p=linux.git

bcachefs: Fix a btree iterator leak

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
---

diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c
index c9de49286fb7a..18f4ba1e305c2 100644
--- a/fs/bcachefs/btree_update_leaf.c
+++ b/fs/bcachefs/btree_update_leaf.c
@@ -858,8 +858,10 @@ static int extent_handle_overwrites(struct btree_trans *trans,
 							  BTREE_ITER_NOT_EXTENTS|
 							  BTREE_ITER_INTENT);
 			ret = bch2_btree_iter_traverse(update_iter);
-			if (ret)
+			if (ret) {
+				bch2_trans_iter_put(trans, update_iter);
 				goto out;
+			}
 
 			bch2_trans_update(trans, update_iter, update,
 					  BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|