From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Mon, 17 Jun 2024 03:28:51 +0000 (+0200)
Subject: hw/sd/sdcard: Have cmd_valid_while_locked() return a boolean value
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=eded0d1a485f3e6279142b88edf444e5e764c9a6;p=qemu.git

hw/sd/sdcard: Have cmd_valid_while_locked() return a boolean value

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20240621080554.18986-14-philmd@linaro.org>
---

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 44225bae9b..04b141784b 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1717,7 +1717,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd,
     return sd_illegal;
 }
 
-static int cmd_valid_while_locked(SDState *sd, const uint8_t cmd)
+static bool cmd_valid_while_locked(SDState *sd, unsigned cmd)
 {
     /* Valid commands in locked state:
      * basic class (0)
@@ -1731,7 +1731,7 @@ static int cmd_valid_while_locked(SDState *sd, const uint8_t cmd)
         return cmd == 41 || cmd == 42;
     }
     if (cmd == 16 || cmd == 55) {
-        return 1;
+        return true;
     }
     return sd_cmd_class[cmd] == 0 || sd_cmd_class[cmd] == 7;
 }