From: Toke Høiland-Jørgensen Date: Thu, 10 Mar 2022 11:02:28 +0000 (+0100) Subject: bpf: Initialise retval in bpf_prog_test_run_xdp() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=eecbfd976e8617125c69e4b3efc89fe34eac7bb1;p=linux.git bpf: Initialise retval in bpf_prog_test_run_xdp() The kernel test robot pointed out that the newly added bpf_test_run_xdp_live() runner doesn't set the retval in the caller (by design), which means that the variable can be passed unitialised to bpf_test_finish(). Fix this by initialising the variable properly. Fixes: b530e9e1063e ("bpf: Add "live packet" mode for XDP in BPF_PROG_RUN") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Toke Høiland-Jørgensen Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/20220310110228.161869-1-toke@redhat.com --- diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c index 25169908be4a4..0acdc37c84151 100644 --- a/net/bpf/test_run.c +++ b/net/bpf/test_run.c @@ -1207,9 +1207,9 @@ int bpf_prog_test_run_xdp(struct bpf_prog *prog, const union bpf_attr *kattr, bool do_live = (kattr->test.flags & BPF_F_TEST_XDP_LIVE_FRAMES); u32 tailroom = SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); u32 batch_size = kattr->test.batch_size; + u32 retval = 0, duration, max_data_sz; u32 size = kattr->test.data_size_in; u32 headroom = XDP_PACKET_HEADROOM; - u32 retval, duration, max_data_sz; u32 repeat = kattr->test.repeat; struct netdev_rx_queue *rxqueue; struct skb_shared_info *sinfo;