From: Jean Sacren Date: Fri, 29 Oct 2021 20:29:45 +0000 (-0600) Subject: blk-mq: fix redundant check of !e expression X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ef1661ba6d2e9c8eecd13ee04067bdcc59f7aac6;p=linux.git blk-mq: fix redundant check of !e expression In the if branch, e is checked. In the else branch, ->dispatch_busy is merely a number and has no effect on !e. We should remove the check of !e since it is always true. Signed-off-by: Jean Sacren Link: https://lore.kernel.org/r/20211029202945.3052-1-sakiwit@gmail.com Signed-off-by: Jens Axboe --- diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index c62b966dfaba5..4a6789e4398b0 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -497,7 +497,7 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx, * busy in case of 'none' scheduler, and this way may save * us one extra enqueue & dequeue to sw queue. */ - if (!hctx->dispatch_busy && !e && !run_queue_async) { + if (!hctx->dispatch_busy && !run_queue_async) { blk_mq_try_issue_list_directly(hctx, list); if (list_empty(list)) goto out;